Fix Perl::Critic violations in tests #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 6, 2017 13:54
... which allows one to avoid a string evaluation in order to check that a given test module is available or not for the POD and Perl::Critic tests. Although this does add one extra dependency for the distribution, it makes the test code adhere to the same Perl best practices that the main code is held to. This change also paves the way for the test files to be checked as part of the `critic.t` tests.
paultcochrane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test files were not adhering to the Perl::Critic standards that the rest of the code is kept to (via the
critic.ttests). These changes bring the test files up to the same best practices standard and allow the test files to also be checked for Perl::Critic violations.This PR is submitted in the hope that it is useful. If it can be improved upon in any way, please just let me know and I'll update and resubmit as necessary.